Debug Loading new markets

[iceman]

Sorry for having post this message in suggestions.....

I'ma using last version of Gary's GreenUp macro.

I have a debug problem when excel automaticly load a new market.

The message error is "run-time 13"

and the debug sign me the part of code written in red below.

Any suggestions?

Private Sub calculateFuturePL(r As Integer, betType As String, stake As Currency, odds As Currency)
Dim i As Integer
For i = 1 To UBound(pl)
If betType = "BACK" Then
If i = r Then
pl(i, 1) = pl(i, 1) + (stake * (odds - 1))
Else
pl(i, 1) = pl(i, 1) - stake
End If
Else
If i = r Then
pl(i, 1) = pl(i, 1) - (stake * (odds - 1))
Else
pl(i, 1) = pl(i, 1) + stake
End If
End If
Next
End Sub

[Captain Sensible]

I'm guessing there must be more code than the snippet you posted but looks like that portion is running before the markets fully loaded and no value has been set for UBound(pl) so you're getting a type mismatch.

Need to step through it all and rearrange the order or look at adding some error trapping so the code won't run until UBound(pl) has a valid value.

[osknows]

Gary's greenup code is pretty robust so not sure why you're getting the error?

The run-time 13 error probably means that the variable 'pl' is Empty and has not been assigned. Have you changed Gary's code?

A 'dirty' fix can be implemented with the code below but I suggest you find out why the variable 'pl' is not being assigned. Perhaps post your amended code here

DIRTY FIX:

Code: Select all

Private Sub calculateFuturePL(r As Integer, betType As String, stake As Currency, odds As Currency)
Dim i As Integer
If Not IsEmpty(pl) Then
    For i = 1 To UBound(pl)
    If betType = "BACK" Then
    If i = r Then
    pl(i, 1) = pl(i, 1) + (stake * (odds - 1))
    Else
    pl(i, 1) = pl(i, 1) - stake
    End If
    Else
    If i = r Then
    pl(i, 1) = pl(i, 1) - (stake * (odds - 1))
    Else
    pl(i, 1) = pl(i, 1) + stake
    End If
    End If
    Next
End If
End Sub


[iceman]

Thanks CAP and Osk, I solve the debug and now It works very fine.
It's only a little slow cancelling unmatched bets in case of few selections,
but this isn't a problem of the greenup macro.
It's probably due to my macro that cancel unmatched befor market turns IP.

Thanks!